[OmniOS-discuss] adding cua/a as a second login

[Paul B. Henson]

On Fri, Jan 02, 2015 at 08:49:37AM +1000, Michael Mounteney wrote:

> 1.  Generally in *nix, items in a list are separated by a colon or a
> space;  rarely a comma.

It's always hard to pick a delimiter for a list containing paths, as
virtually every convenient character is also a valid part of a path :).
As this is a list of devices, I thought commas would be less prevailent
than colons. Could have gone the other way I suppose. I don't really
care myself, if the review concensus is to change it before integration
I'll change it...

> 2.  If login is attempted on a device not in the CONSOLE list, the
> error message is "not on system console" which is slightly misleading;
> I think the message should be "login not allowed on this device" or
> similar.

That message was already misleading, the "system console" could be the
framebuffer, but CONSOLE set to /dev/ttya, so when logging in to the
actual system console you'd be told you weren't on the system console
;). I generally try to go with the least invasive changes needed to
implement the new functionality, so tweaking that message wasn't really
on my radar.