[OmniOS-discuss] issue 8984 (fix for 6764 breaks ACL inheritance)

[Andries Annema]

Hi Andy (and list),

Following the release of r151022ap, I updated my testing VM and poked 
around a bit trying to verify whether the 8984 issue is now indeed 
properly resolved. Well, on the one hand it is, but on the other... I'm 
getting a bit confused whether it is, or if there is something else 
going on still.

It looks like the ACL inheritance issue is indeed resolved when:
- creating files or making directories from CLI (touch, mkdir),
- copying files from CLI (cp),
- creating/copying files from Windows through CIFS/SMB-share (there was 
nothing wrong with that in the first place).

But the issue seems unresolved when:
- using rsync to copy stuff over from one dataset to another.

Check out the output below; I suppose the filenames speak for themselves.

SOURCE DATASET:

root at vm01omniosce ~ # /usr/bin/ls -lVd /tank/media/music
drwxrws---+  4 root     media          7 Mar  8 15:48 /tank/media/music
                  owner@:rwxpdDaARWcCos:-d-----:allow
                  owner@:rw-pdDaARWc--s:f------:allow
                  group@:rwxp--a-R-c--s:-d-----:allow
                  group@:rw-p--a-R-c--s:f------:allow
           group:mediaro:r-x---a-R-c--s:-d-----:allow
           group:mediaro:r-----a-R-c--s:f------:allow
               everyone@:------a-R-c--s:fd-----:allow


TARGET DATASET:

root at vm01omniosce ~ # /usr/bin/ls -lVd /tank/media_uncategorized/
drwxrws---+  4 root     media          7 Mar  8 15:48 
/tank/media_uncategorized/
               user:an3s:rwxpdDaARWcCos:-d-----:allow
               user:an3s:rw-pdDaARWc--s:f------:allow
              user:dlmgr:rwxp--aARWc--s:-d-----:allow
              user:dlmgr:rw-p--aARWc--s:f------:allow
                  owner@:rwxpdDaARWcCos:-d-----:allow
                  owner@:rw-pdDaARWc--s:f------:allow
                  group@:rwxp--aARWc--s:-d-----:allow
                  group@:rw-p--aARWc--s:f------:allow
           group:mediaro:r-x---a-R-c--s:-d-----:allow
           group:mediaro:r-----a-R-c--s:f------:allow
               everyone@:------a-R-c--s:fd-----:allow


ACL RESULT AFTER DIFFERENT ACTIONS:

root at vm01omniosce ~ # /usr/bin/ls -lV /tank/media_uncategorized/*.mp3
-rw-rw----+  1 an3s     media    11613081 Mar  8 16:15 
/tank/media_uncategorized/file-copied-from-win7.mp3
               user:an3s:rw-pdDaARWc--s:------I:allow
              user:dlmgr:rw-p--aARWc--s:------I:allow
                  owner@:rw-pdDaARWc--s:------I:allow
                  group@:rw-p--aARWc--s:------I:allow
           group:mediaro:r-----a-R-c--s:------I:allow
               everyone@:------a-R-c--s:------I:allow
-rw-rw----+  1 root     media    11613081 Mar  8 16:15 
/tank/media_uncategorized/file-cp'd.mp3
               user:an3s:rw-pdDaARWc--s:------I:allow
              user:dlmgr:rw-p--aARWc--s:------I:allow
                  owner@:rw-pdDaARWc--s:------I:allow
                  group@:rw-p--aARWc--s:------I:allow
           group:mediaro:r-----a-R-c--s:------I:allow
               everyone@:------a-R-c--s:------I:allow
-rw-rw----+  1 root     media          0 Mar  8 16:27 
/tank/media_uncategorized/file-created-from-cli.mp3
               user:an3s:rw-pdDaARWc--s:------I:allow
              user:dlmgr:rw-p--aARWc--s:------I:allow
                  owner@:rw-pdDaARWc--s:------I:allow
                  group@:rw-p--aARWc--s:------I:allow
           group:mediaro:r-----a-R-c--s:------I:allow
               everyone@:------a-R-c--s:------I:allow
-rw-r-----+  1 an3s     media    11613081 Feb 23 21:02 
/tank/media_uncategorized/file-rsync'd-options-rltgoDu.mp3
               user:an3s:rw-pdDaARWc--s:------I:allow
              user:dlmgr:rw-p--aARWc--s:------I:allow
           group:mediaro:r-----a-R-c--s:------I:allow
                  owner@:rw-p--aARWcCos:-------:allow
                  group@:r-----a-R-c--s:-------:allow
               everyone@:------a-R-c--s:-------:allow
-rw-rw----+  1 an3s     media    11613081 Feb 23 21:02 
/tank/media_uncategorized/file-rsync'd-options-rltgoDupAX.mp3
               user:an3s:rw-pdDaARWc--s:------I:allow
              user:dlmgr:rw-p--aARWc--s:------I:allow
           group:mediaro:r-----a-R-c--s:------I:allow
                  owner@:rw-p--aARWcCos:-------:allow
                  group@:rw-p--a-R-c--s:-------:allow
               everyone@:------a-R-c--s:-------:allow


Only the rsync'd file does not inherit the ACE's properly. Does this 
make any sense?
I'm using the rsync release from https://pkg.omniosce.org/r151022/core/, 
rsync version 3.1.3-0.151022:20180129T134935Z.

Modifying the rsync options (see file names) doesn't actually really 
matter: the inheritance is broken.

Any thoughts are appreciated! Tnx.

Cheers,
Andries


On 2018-02-18 20:43, Andy Fiddaman wrote:
> On Sun, 18 Feb 2018, Andries Annema wrote:
>
> ; Playing around with r151022, I may have bumped into the same issue here.
> ; The ACE's that I set on the parent directory are nicely inherited, but
> ; on top of that, another ACE for owner@, group@ and everyone@ is added.
>
> Hi,
>
> This does sound like the same issue and we have a fix for this currently in
> testing for OmniOS r151022 which we plan to upstream when it's ready.
>
> If you want to test the hot-fix, a package archive containing an updated
> zfs pachage is available for download at:
>
> https://downloads.omniosce.org/pkg/8984_r151022.p5p
>
> to install please proceed as follows (assuming the downloaded archive
> is in /root):
>
> # pkg set-publisher -g /root/8984_r151022.p5p omnios
> # pkg update -v --be-name=...
> # init 6
> # pkg set-publisher -G /root/8984_r151022.p5p omnios
>
> Andy
>