[OmniOS-discuss] Newer pkg list -v no longer displays build version

Dan McDonald danmcd at omniti.com
Wed Apr 8 20:03:44 UTC 2015


> On Apr 8, 2015, at 2:59 PM, Lauri Tirkkonen <lotheac at iki.fi> wrote:
> 
> On Wed, Apr 08 2015 14:39:20 -0400, Eric Sproul wrote:
>> The updated pkg(5) in 014 changes the default format for versions in
>> `pkg list -v` output.  Previously, the format was:
>> 
>> component,build-branch:timestamp
>> 
>> now it appears to be:
>> 
>> component-branch:timestamp
> 
> Good catch, thanks for the heads up. The build version has also been
> removed from pkg info output (both the separate line as well as the
> version in the FMRI). I'm also interested in the history; pkg(5) does
> still document that the build version is part of the FMRI.

THE BIG QUESTION is whether or not it's something worth fixing, or just something worth documenting more.  Alas, we don't have insight into Oracle's thinking here, but somebody thought it would be a good idea.  Here's the commit:

commit 70a649f9f2f9702950b250e1add20d2732df6b94
Author: Yiteng Zhang <yiteng.zhang at oracle.com>
Date:   Fri Sep 27 11:38:34 2013 -0700

    16851082 build_release (aka build version) should not be displayed

 src/client.py                            | 31 ++++++++++++++++++++++---------
 src/modules/actions/depend.py            | 10 ++++------
 src/modules/catalog.py                   | 29 +++++++++--------------------
 src/modules/client/api.py                | 37 ++++++++++++++-----------------------
 src/modules/client/image.py              | 23 +++++++----------------
 src/modules/client/imageplan.py          | 39 +++++++++++++--------------------------
 src/modules/client/linkedimage/common.py |  5 +----
 src/modules/client/pkg_solver.py         | 15 +++++++--------
 src/modules/config.py                    |  2 +-
 src/modules/fmri.py                      |  7 ++++---
 src/modules/lint/engine.py               |  3 +--
 src/modules/lint/pkglint_action.py       |  8 +++-----
 src/modules/lint/pkglint_manifest.py     |  5 ++---
 src/modules/manifest.py                  |  3 +--
 src/modules/mediator.py                  |  6 +++---
 src/modules/publish/dependencies.py      | 25 ++++++++++++-------------
 src/modules/server/api.py                |  6 +++---
 src/modules/version.py                   | 35 +++++++++++++++--------------------
 src/pkgrepo.py                           | 15 ++++++++++++---
 src/publish.py                           |  2 +-
 src/pull.py                              |  7 ++++---
 src/sign.py                              |  3 ++-
 src/tests/api/t_api_list.py              | 10 ++++------
 src/tests/api/t_catalog.py               |  8 ++++----
 src/tests/api/t_fmri.py                  | 19 +++++++------------
 src/tests/api/t_p5i.py                   |  2 +-
 src/tests/api/t_pkg_api_install.py       |  2 +-
 src/tests/api/t_version.py               |  8 +-------
 src/tests/cli/t_depot_config.py          |  4 +++-
 src/tests/cli/t_fix.py                   |  2 +-
 src/tests/cli/t_pkg_composite.py         |  3 +--
 src/tests/cli/t_pkg_info.py              | 47 +++++++++++++++++------------------------------
 src/tests/cli/t_pkg_install.py           |  4 ++--
 src/tests/cli/t_pkg_linked.py            |  6 +++---
 src/tests/cli/t_pkg_temp_sources.py      | 24 ++++++++++++------------
 src/tests/cli/t_pkgdep_resolve.py        |  2 +-
 src/tests/cli/t_pkgmerge.py              |  8 ++++----
 src/tests/cli/t_pkgrecv.py               | 16 ++++++++++------
 src/tests/cli/t_pkgrepo.py               | 49 ++++++++++++++++++++++++++++++++++++++-----------
 src/tests/cli/t_pkgsend.py               |  8 ++++----
 src/tests/cli/t_publish_api.py           |  4 ++--
 src/tests/cli/t_util_merge.py            |  2 +-
 src/tests/perf/fmribench.py              |  6 +++---
 src/tests/perf/membench.py               |  4 ++--
 src/util/publish/pkglint.py              |  3 +--
 src/util/publish/pkgmerge.py             | 14 ++++----------
 src/util/publish/pkgsurf.py              |  8 ++++----
 src/web/en/catalog.shtml                 |  2 +-
 src/web/en/search.shtml                  |  2 +-
 49 files changed, 274 insertions(+), 309 deletions(-)


That's a LOT of changes.

A quick "git revert" test showed only one file in conflict, oddly enough.  It might be worth trying to build this change and generate a webrev for inspection.

Dan



More information about the OmniOS-discuss mailing list