[OmniOS-discuss] PERL booleans?

[Dan McDonald]

I upgraded my HDC to OmniOSce r151024, and did some nightly builds.  After re-rewhacking PERL_VERS, I managed to get a MOSTLY clean build save for:

> Begin forwarded message:
> 
> From: Dan McDonald <danmcd at nowhere.kebe.com>
> Subject: Nightly i386 Build of illumos-gate Failed.
> Date: November 6, 2017 at 11:41:49 PM EST
> To: danmcd at nowhere.kebe.com
> 
> 
> ==== Nightly distributed build started:   Mon Nov  6 22:34:21 EST 2017 ====
> ==== Nightly distributed build completed: Mon Nov  6 23:41:49 EST 2017 ====
> 
> ==== Total build time ====
> 
> real    1:07:28
> 
> ==== Build environment ====
> 
> /usr/bin/uname
> SunOS nowhere 5.11 omnios-r151024-c2a1589567 i86pc i386 i86pc

<SNIP!>

> ==== Build warnings (non-DEBUG) ====
> 
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> WARNING: The token "BOOL" is deprecated; use "BOOLEAN" instead
> 
> ==== Elapsed build time (non-DEBUG) ====

The file $SRC/cmd/hal/hald/hald_marshal.list uses "BOOL" and under an updated glib (which is in the new OmniOS) should be "BOOLEAN".

OmniOS has this fix now:

commit f1311a377c43d15cc090269298266c6daacb47ac
Author: citrus-it <omnios at citrus-it.co.uk>
Date:   Wed Sep 20 07:59:04 2017 +0000

    Replace deprecated glob marshal BOOL with BOOLEAN

I was curious if anyone who's not building on OmniOS has tried making this change? It should be a NOP on SmartOS because we don't use or even manifest hald.

Thanks,
Dan